Skip to content

Conversation

@hiroshihorie
Copy link
Member

#784 Broke LocalAudioTrack.add(audioRenderer: AudioRenderer) so this PR fixes it...

@hiroshihorie hiroshihorie requested a review from pblazej October 8, 2025 13:14
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

⚠️ This PR does not contain any files in the .changes directory.

@pblazej
Copy link
Contributor

pblazej commented Oct 9, 2025

Trying to understand the remaining failures (iOS device) here:
Screenshot 2025-10-09 at 8 51 09 AM

testStartingTwice() is redundant, as the API just changed (to stop first).

Can we do sth about the others?

@hiroshihorie
Copy link
Member Author

Yea most of them need to run with LKTestHost + local LK server running. Without the test host these audio test are blocked at mic perms I think 🤔 Also tests can't run concurrently because its sharing the ADM singleton.

@pblazej
Copy link
Contributor

pblazej commented Oct 16, 2025

Yea most of them need to run with LKTestHost + local LK server running. Without the test host these audio test are blocked at mic perms I think 🤔 Also tests can't run concurrently because its sharing the ADM singleton.

Yes, I'm referring to LKTestHost here. The new test plans are not concurrent, just random. You can try running them on device as well.

@pblazej
Copy link
Contributor

pblazej commented Oct 17, 2025

Let's unblock main and sync on the rest next week.

@hiroshihorie hiroshihorie merged commit 017ea2d into main Oct 18, 2025
21 of 27 checks passed
@hiroshihorie hiroshihorie deleted the hiroshi/fix-renderer-adapter branch October 18, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants